Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release workflow improvements #3157

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

jenniferarnesen
Copy link
Collaborator

@jenniferarnesen jenniferarnesen commented Dec 4, 2024

There are 2 main improvements to the workflow to help solve all the failing builds:

image
  • Instead of complex if statements in the gh workflow file (they aren't even working anyway!), use commit_analyzer config to prevent release for our [skip release] and [skip ci] PRs.
  • Publishing to AppHub fails if there is no build file, which there won't be in the case of chores and [skip release]. So add an if statement that checks that a build was made. The output gets set to "yes" if there is a build.
  • The report-release-result job should always run. But it should only report a success message if there is a build and the release step was successful (which is not only the build file but also whether it was published to apphub)

Here's some workflow outputs from an example app that demonstrate the above changes in a test repo:
build_exists has been set to true and Publish AppHub runs: https://github.com/jenniferarnesen/dhis2-ci-demo/actions/runs/11667460947/job/32484827377

Skip publishing to App hub when [skip release] (even when the commit was a fix or feature): https://github.com/jenniferarnesen/dhis2-ci-demo/actions/runs/11681915720/job/32527955692#step:5:55

Copy link

sonarqubecloud bot commented Dec 4, 2024

@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-3157.dashboard.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify December 4, 2024 13:25 Inactive
@jenniferarnesen jenniferarnesen merged commit ec57edd into master Dec 4, 2024
36 checks passed
@jenniferarnesen jenniferarnesen deleted the chore/release-workflow-improvements branch December 4, 2024 13:40
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants